Sha512 and base64 support #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Force named hashes to be valid. After all, what would be the point of naming an invalid hash ? This avoids propagating manually the ValidAlgo requirement everywhere.
cryptohash-sha512 is not yet updated to work with ghc 8.10. Some jailbreaking is required.
sorki
approved these changes
Nov 9, 2020
Member
sorki
left a comment
sorki
left a comment
There was a problem hiding this comment.
LGTM, tested with my systems Nix database. I'll try to fix contentAddressableAddressBuilder in similar manner and we can possibly add some round-trip tests for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #64 which is fairly trivial and contains only small fixes.